RE: [net-next 05/11] i40e: fix for queue timing delays

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Saturday, March 25, 2017 8:01 PM
To: Kirsher, Jeffrey T <redacted>
Cc: Wyborny, Carolyn <redacted>;
netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
jogreene@redhat.com
Subject: Re: [net-next 05/11] i40e: fix for queue timing delays

From: Jeff Kirsher <redacted>
Date: Sat, 25 Mar 2017 01:12:59 -0700

quoted

From: Carolyn Wyborny <redacted>

This patch adds a delay to Rx queue disables to accommodate HW needs.

[..]

quoted

+	/* HW needs up to 50ms to finish RX queue disable*/
+	mdelay(50);

You just polled a register which indicates that the request is finished.
Needing futher time for the operation to complete doesn't make any
sense.

If this is really needed, you need to explain in the commit message, in
detail, what is really the problem here.

THanks.

It's a hw limitation, will submit an updated patch with more detail.

Thanks,

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation