Re: [net-next 05/11] i40e: fix for queue timing delays
From: David Miller <davem@davemloft.net>
Date: 2017-03-26 03:00:56
From: Jeff Kirsher <redacted> Date: Sat, 25 Mar 2017 01:12:59 -0700
quoted hunk ↗ jump to hunk
From: Carolyn Wyborny <redacted> This patch adds a delay to Rx queue disables to accommodate HW needs. Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1 Signed-off-by: Carolyn Wyborny <redacted> Tested-by: Andrew Bowers <redacted> Signed-off-by: Jeff Kirsher <redacted> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 5da990909a88..1435033faefe 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c@@ -4181,6 +4181,8 @@ static int i40e_vsi_control_rx(struct i40e_vsi *vsi, bool enable) } } + /* HW needs up to 50ms to finish RX queue disable*/ + mdelay(50);
You just polled a register which indicates that the request is finished. Needing futher time for the operation to complete doesn't make any sense. If this is really needed, you need to explain in the commit message, in detail, what is really the problem here. THanks.