Thread (15 messages) flat view 15 messages, 4 authors, 2017-03-17

RE: [PATCH 07/10] netfilter: Force fake conntrack entry to be at least 8 bytes aligned

From: David Laight <hidden>
Date: 2017-03-16 09:55:43
Also in: netfilter-devel

From: Pablo Neira Ayuso
Sent: 15 March 2017 17:01
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

Since the nfct and nfctinfo have been combined, the nf_conn structure
must be at least 8 bytes aligned, as the 3 LSB bits are used for the
nfctinfo. But there's a fake nf_conn structure to denote untracked
connections, which is created by a PER_CPU construct. This does not
guarantee that it will be 8 bytes aligned and can break the logic in
determining the correct nfctinfo.
Can't you just add an __aligned(8) onto the structure definition?

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help