Thread (10 messages) flat view 10 messages, 4 authors, 2017-03-15

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

From: Jarod Wilson <hidden>
Date: 2017-03-15 20:49:52

On 2017-03-08 4:33 PM, David Arcari wrote:
When the aquantia device mtu is changed the net_device structure is not
updated.  As a result the ip command does not properly reflect the mtu change.

Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu;  This is not true in the case where the driver
has a ndo_change_mtu routine.

Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")

Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
Looks like an appropriate and necessary fix to me.

Reviewed-by: Jarod Wilson <redacted>

-- 
Jarod Wilson
jarod@redhat.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help