From: David Arcari <hidden> Date: 2017-03-08 22:27:42
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
---
drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
1 file changed, 1 insertion(+)
From: Pavel Belous <hidden> Date: 2017-03-09 19:03:07
On 09.03.2017 00:33, David Arcari wrote:
quoted hunk
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
---
drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
1 file changed, 1 insertion(+)
From: David Arcari <hidden> Date: 2017-03-09 20:02:13
On 03/09/2017 02:02 PM, Pavel Belous wrote:
On 09.03.2017 00:33, David Arcari wrote:
quoted
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
---
drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
1 file changed, 1 insertion(+)
From: David Arcari <hidden> Date: 2017-03-09 20:28:45
On 03/09/2017 03:01 PM, David Arcari wrote:
On 03/09/2017 02:02 PM, Pavel Belous wrote:
quoted
On 09.03.2017 00:33, David Arcari wrote:
quoted
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
---
drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
1 file changed, 1 insertion(+)
@@ -98,6 +98,7 @@ static int aq_ndev_change_mtu(struct net_device *ndev, int
new_mtu)
if (err < 0)
goto err_exit;
+ ndev->mtu = new_mtu;
if (netif_running(ndev)) {
aq_ndev_close(ndev);
Thank you, David.
I think we should also remove closing/opening net-device after mtu changed.
Hi Pavel,
I'll go ahead and submit v2.
Thanks,
-Dave
Hi Pavel,
Before I post v2, won't that mean that if the interface is up that the user will
have to manually toggle it for the new mtu to take effect?
Is that the desired behavior?
Thanks,
-Dave
From: Pavel Belous <hidden> Date: 2017-03-09 20:57:45
On 09.03.2017 23:28, David Arcari wrote:
On 03/09/2017 03:01 PM, David Arcari wrote:
quoted
On 03/09/2017 02:02 PM, Pavel Belous wrote:
quoted
On 09.03.2017 00:33, David Arcari wrote:
quoted
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
---
drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
1 file changed, 1 insertion(+)
@@ -98,6 +98,7 @@ static int aq_ndev_change_mtu(struct net_device *ndev, int
new_mtu)
if (err < 0)
goto err_exit;
+ ndev->mtu = new_mtu;
if (netif_running(ndev)) {
aq_ndev_close(ndev);
Thank you, David.
I think we should also remove closing/opening net-device after mtu changed.
Hi Pavel,
I'll go ahead and submit v2.
Thanks,
-Dave
Hi Pavel,
Before I post v2, won't that mean that if the interface is up that the user will
have to manually toggle it for the new mtu to take effect?
Is that the desired behavior?
Thanks,
-Dave
quoted
quoted
Regards,
Pavel
No. The new mtu will take effect immediately.
Closing/opening is not needed at all.
Regards,
Pavel
From: David Miller <davem@davemloft.net> Date: 2017-03-13 06:09:21
From: David Arcari <redacted>
Date: Wed, 8 Mar 2017 16:33:21 -0500
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
From: David Arcari <hidden> Date: 2017-03-13 15:50:50
On 03/13/2017 02:09 AM, David Miller wrote:
From: David Arcari <redacted>
Date: Wed, 8 Mar 2017 16:33:21 -0500
quoted
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
Applied, thanks.
Hi David,
I see that my patch:
"net: ethernet: aquantia: call set_irq_affinity_hint before free_irq"
has been applied to net, but I don't see that this patch has been applied.
Is there any chance that you replied to the wrong patch? Or am I missing something?
Thanks,
-Dave
From: David Miller <davem@davemloft.net> Date: 2017-03-13 19:56:16
From: David Arcari <redacted>
Date: Mon, 13 Mar 2017 11:50:50 -0400
On 03/13/2017 02:09 AM, David Miller wrote:
quoted
From: David Arcari <redacted>
Date: Wed, 8 Mar 2017 16:33:21 -0500
quoted
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
Applied, thanks.
Hi David,
I see that my patch:
"net: ethernet: aquantia: call set_irq_affinity_hint before free_irq"
has been applied to net, but I don't see that this patch has been applied.
It is marked as "changes requested" in patchwork, because you were asked to
do the restart label removal in a separate patch.
From: David Arcari <hidden> Date: 2017-03-13 23:02:02
On 03/13/2017 03:56 PM, David Miller wrote:
From: David Arcari <redacted>
Date: Mon, 13 Mar 2017 11:50:50 -0400
quoted
On 03/13/2017 02:09 AM, David Miller wrote:
quoted
From: David Arcari <redacted>
Date: Wed, 8 Mar 2017 16:33:21 -0500
quoted
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
Applied, thanks.
Hi David,
I see that my patch:
"net: ethernet: aquantia: call set_irq_affinity_hint before free_irq"
has been applied to net, but I don't see that this patch has been applied.
It is marked as "changes requested" in patchwork, because you were asked to
do the restart label removal in a separate patch.
Sorry, I was not clear. I was trying to ask if your "Applied, thanks" reply
(above) was meant for this email thread. I believe it was meant for the
set_irq_affinity_hint patch.
Thanks,
-DA
From: Jarod Wilson <hidden> Date: 2017-03-15 20:49:52
On 2017-03-08 4:33 PM, David Arcari wrote:
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the driver
has a ndo_change_mtu routine.
Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
Cc: Pavel Belous <redacted>
Signed-off-by: David Arcari <redacted>
Looks like an appropriate and necessary fix to me.
Reviewed-by: Jarod Wilson <redacted>
--
Jarod Wilson
jarod@redhat.com