Thread (17 messages) flat view 17 messages, 3 authors, 2017-03-07

RE: [PATCH net 3/7 v2] bnx2x: fix possible overrun of VFPF multicast addresses array

From: Mintz, Yuval <hidden>
Date: 2017-03-07 19:34:25

It is too late to check for the limit of the number of VF multicast addresses
after they have already been copied to the req->multicast[] array, possibly
overflowing it.

Do the check before copying.

Checking early also avoids having to (and forgetting to) unlock vf2pf_mutex.

While we're looking at the error paths in the function, also return an error
code from it when the PF responds with an error. Even though the caller
ignores it.

v2: Move the check before bnx2x_vfpf_prep() as suggested by Yuval.

Signed-off-by: Michal Schmidt <redacted>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help