RE: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, January 18, 2017 1:29 PM
To: Grandhi, Sainath <redacted>
Cc: netdev@vger.kernel.org; mahesh@bandewar.net; linux-
kernel@vger.kernel.org
Subject: Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

From: Sainath Grandhi <redacted>
Date: Tue, 17 Jan 2017 16:03:06 -0800

quoted

+static void ipvtap_count_tx_dropped(struct tap_dev *tap) {
+	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
+ipvtap_dev, tap);

 ...

quoted

+static void ipvtap_count_rx_dropped(struct tap_dev *tap) {
+	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
+ipvtap_dev, tap);

 ...

quoted

+static void ipvtap_update_features(struct tap_dev *tap,
+				   netdev_features_t features)
+{
+	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct
+ipvtap_dev, tap);

More unnecessary casts, please remove.

Will take care of it in next revision. Thanks.