Re: [PATCHv2 4/7] TAP: Abstract type of virtual interface from tap implementation
From: David Miller <davem@davemloft.net>
Date: 2017-01-18 21:27:33
Also in:
lkml
From: Sainath Grandhi <redacted> Date: Tue, 17 Jan 2017 16:03:03 -0800
quoted hunk ↗ jump to hunk
@@ -46,22 +51,52 @@ static struct cdev macvtap_cdev; #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \ NETIF_F_TSO6 | NETIF_F_UFO) +static void macvtap_count_tx_dropped(struct tap_dev *tap) +{ + struct macvlan_dev *vlan = (struct macvlan_dev *)container_of(tap, struct macvtap_dev, tap);
...
+static void macvtap_count_rx_dropped(struct tap_dev *tap)
+{
+ struct macvlan_dev *vlan = (struct macvlan_dev *)container_of(tap, struct macvtap_dev, tap);...
+static void macvtap_update_features(struct tap_dev *tap,
+ netdev_features_t features)
+{
+ struct macvlan_dev *vlan = (struct macvlan_dev *)container_of(tap, struct macvtap_dev, tap);These casts should be completely unnecessary, please remove them.