Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include
From: David Miller <davem@davemloft.net>
Date: 2017-01-18 21:51:15
Also in:
lkml
From: Russell King - ARM Linux <linux@armlinux.org.uk> Date: Wed, 18 Jan 2017 21:46:28 +0000
On Wed, Jan 18, 2017 at 04:37:14PM -0500, David Miller wrote:quoted
From: Russell King - ARM Linux <linux@armlinux.org.uk> Date: Wed, 18 Jan 2017 00:14:03 +0000quoted
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSIZ. Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h and phy_fixed.h from net/dsa.h. This patch reduces from around 800 files rebuilt to around 40 - even with ccache, the time difference is noticable. Signed-off-by: Russell King <redacted>Applied, thanks.Hmm, now that's _really_ interesting.
It got reviewed-by and seemed reasonable. I am always allowed to use my judgment to turn an RFC into a patch I actually apply, especially when other developers review the change. If you read your email now you'll see that I reverted it before pushing it out, because of the fallout you mention.