Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include
From: Vivien Didelot <hidden>
Date: 2017-01-18 01:12:21
Also in:
lkml
From: Vivien Didelot <hidden>
Date: 2017-01-18 01:12:21
Also in:
lkml
Hi Russell, Russell King - ARM Linux [off-list ref] writes:
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSIZ. Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h and phy_fixed.h from net/dsa.h. This patch reduces from around 800 files rebuilt to around 40 - even with ccache, the time difference is noticable. Signed-off-by: Russell King <redacted>
This patch applies cleanly on net-next and builds correctly after
touching include/linux/phy.h. My boards work fine with it.
Tested-by: Vivien Didelot <redacted>
Thanks,
Vivien