Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-01-18 00:05:03
Also in:
linux-arm-kernel, lkml
On 01/17/2017 04:00 PM, Andy Shevchenko wrote:
On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli [off-list ref] wrote:quoted
On 01/17/2017 03:34 PM, Andy Shevchenko wrote:quoted
On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli [off-list ref] wrote:quoted
quoted
quoted
+static int device_class_name_match(struct device *dev, void *class)And why not const char *class?This was raised back in v2, and the same response applies: https://www.mail-archive.com/netdev@vger.kernel.org/msg147559.html Changing the signature of a callback is out of the scope of this patch series.Ah, right. But why not to use void *class_name to be consistent with callback and device_find_child()?
The top-level function: device_find_in_class_name() should have a stronger typing of its argument even if it internally uses device_find_child() and a callback that takes a void * argument, that's how I see it.
Btw, return get_device(parent);
Not sure I follow what that means here? -- Florian