Thread (22 messages) flat view 22 messages, 5 authors, 2017-01-14

Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-01-13 14:05:14
Also in: linux-arm-kernel, lkml

quoted hunk ↗ jump to hunk
index cd91070b5467..d326fc4afad7 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -81,17 +81,23 @@ static void dsa_dst_del_ds(struct dsa_switch_tree *dst,
 
 static bool dsa_port_is_valid(struct dsa_port *port)
 {
-	return !!port->dn;
+	return !!(port->dn || port->name);
 }
  
Does this clash with Viviens recent change to make names optional and
have the kernel assign it?

I suppose you could use an name of "eth%d"? Is it worth adding a
comment to the platform data structure?

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help