Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

On Wed, 2017-01-11 at 21:39 +0100, Arnd Bergmann wrote:

On Wednesday, January 11, 2017 4:06:17 PM CET Johannes Berg wrote:

quoted

Applied. Also fixed the typo in the subject :)

Thanks! Unfortunately I now got another warning for the same
function, and though I would have expected the patch to fix it, that
did not work:

In file included from /git/arm-
soc/drivers/net/wireless/intersil/prism54/islpci_dev.h:27:0,
                 from /git/arm-
soc/drivers/net/wireless/intersil/prism54/isl_ioctl.h:24,
                 from /git/arm-
soc/drivers/net/wireless/intersil/prism54/isl_ioctl.c:32:
/git/arm-soc/drivers/net/wireless/intersil/prism54/isl_ioctl.c: In
function 'prism54_get_scan':
/git/arm-soc/include/net/iw_handler.h:560:4: error: argument 2 null
where non-null expected [-Werror=nonnull]
    memcpy(stream + point_len, extra, iwe->u.data.length);

And I realized only now that this was a different place ...

I've just added the check you suggested - spent way too much time
already on this old crap :)

johannes