Thread (3 messages) flat view 3 messages, 2 authors, 2017-01-11

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-01-11 14:38:51
Also in: linux-wireless, lkml

On Wed, 2017-01-11 at 15:35 +0100, Arnd Bergmann wrote:
gcc-7 complains that wl3501_cs passes NULL into a function that
then uses the argument as the input for memcpy:

drivers/net/wireless/wl3501_cs.c: In function 'wl3501_get_scan':
include/net/iw_handler.h:559:3: error: argument 2 null where non-null 
expected [-Werror=nonnull]
   memcpy(stream + point_len, extra, iwe->u.data.length);
I love wext ;-)
This works fine here because iwe->u.data.length is guaranteed to be
NULL, and the memcpy doesn't actually have an effect.
I think you mean 0, not NULL, but I can fix that when I apply it.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help