Re: [net, 2/6] net: korina: define NAPI_WEIGHT

On 01/17/2017 10:30 AM, Roman Yeryomin wrote:

On 17 January 2017 at 19:40, David Miller [off-list ref] wrote:

quoted

From: Roman Yeryomin <redacted>
Date: Tue, 17 Jan 2017 19:32:22 +0200

quoted

@@ -77,6 +77,8 @@

 #define MII_CLOCK 1250000    /* no more than 2.5MHz */

+#define NAPI_WEIGHT  64
+
 /* the following must be powers of two */
 #define KORINA_NUM_RDS       64  /* number of receive descriptors */
 #define KORINA_NUM_TDS       64  /* number of transmit descriptors */

@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
      dev->netdev_ops = &korina_netdev_ops;
      dev->ethtool_ops = &netdev_ethtool_ops;
      dev->watchdog_timeo = TX_TIMEOUT;
-     netif_napi_add(dev, &lp->napi, korina_poll, 64);
+     netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);

Please use NAPI_POLL_WEIGHT from linux/netdevice.h

OK, should I resend the whole set or just this one and dependant?

You need to resend everything and please also provide a cover letter,
and a proper patch subject (e.g: git format-patch --cover-letter
--subject="PATCH net-next v2" a..b)

Thanks!
-- 
Florian