[net, 2/6] net: korina: define NAPI_WEIGHT

Subsystems: networking drivers, the rest

5 messages, 3 authors, 2017-01-17 · open the first message on its own page

[net, 2/6] net: korina: define NAPI_WEIGHT

From: Roman Yeryomin <hidden>
Date: 2017-01-17 17:32:29

Signed-off-by: Roman Yeryomin <redacted>
---
 drivers/net/ethernet/korina.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index 9bc375d..45bd617 100644
--- a/drivers/net/ethernet/korina.c
+++ b/drivers/net/ethernet/korina.c

@@ -77,6 +77,8 @@
 
 #define MII_CLOCK 1250000 	/* no more than 2.5MHz */
 
+#define NAPI_WEIGHT	64
+
 /* the following must be powers of two */
 #define KORINA_NUM_RDS	64  /* number of receive descriptors */
 #define KORINA_NUM_TDS	64  /* number of transmit descriptors */

@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
 	dev->netdev_ops = &korina_netdev_ops;
 	dev->ethtool_ops = &netdev_ethtool_ops;
 	dev->watchdog_timeo = TX_TIMEOUT;
-	netif_napi_add(dev, &lp->napi, korina_poll, 64);
+	netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
 
 	lp->phy_addr = (((lp->rx_irq == 0x2c? 1:0) << 8) | 0x05);
 	lp->mii_if.dev = dev;

-- 
2.7.4

Re: [net, 2/6] net: korina: define NAPI_WEIGHT

From: David Miller <davem@davemloft.net>
Date: 2017-01-17 17:40:10

From: Roman Yeryomin <redacted>
Date: Tue, 17 Jan 2017 19:32:22 +0200

quoted hunk

@@ -77,6 +77,8 @@
 
 #define MII_CLOCK 1250000 	/* no more than 2.5MHz */
 
+#define NAPI_WEIGHT	64
+
 /* the following must be powers of two */
 #define KORINA_NUM_RDS	64  /* number of receive descriptors */
 #define KORINA_NUM_TDS	64  /* number of transmit descriptors */
@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
 	dev->netdev_ops = &korina_netdev_ops;
 	dev->ethtool_ops = &netdev_ethtool_ops;
 	dev->watchdog_timeo = TX_TIMEOUT;
-	netif_napi_add(dev, &lp->napi, korina_poll, 64);
+	netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);

Please use NAPI_POLL_WEIGHT from linux/netdevice.h

Re: [net, 2/6] net: korina: define NAPI_WEIGHT

From: Roman Yeryomin <hidden>
Date: 2017-01-17 18:30:55

On 17 January 2017 at 19:40, David Miller [off-list ref] wrote:

From: Roman Yeryomin <redacted>
Date: Tue, 17 Jan 2017 19:32:22 +0200

quoted

@@ -77,6 +77,8 @@

 #define MII_CLOCK 1250000    /* no more than 2.5MHz */

+#define NAPI_WEIGHT  64
+
 /* the following must be powers of two */
 #define KORINA_NUM_RDS       64  /* number of receive descriptors */
 #define KORINA_NUM_TDS       64  /* number of transmit descriptors */
@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
      dev->netdev_ops = &korina_netdev_ops;
      dev->ethtool_ops = &netdev_ethtool_ops;
      dev->watchdog_timeo = TX_TIMEOUT;
-     netif_napi_add(dev, &lp->napi, korina_poll, 64);
+     netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);

Please use NAPI_POLL_WEIGHT from linux/netdevice.h

OK, should I resend the whole set or just this one and dependant?

Regards,
Roman

Re: [net, 2/6] net: korina: define NAPI_WEIGHT

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-01-17 18:33:19

On 01/17/2017 10:30 AM, Roman Yeryomin wrote:

On 17 January 2017 at 19:40, David Miller [off-list ref] wrote:

quoted

From: Roman Yeryomin <redacted>
Date: Tue, 17 Jan 2017 19:32:22 +0200

quoted

@@ -77,6 +77,8 @@

 #define MII_CLOCK 1250000    /* no more than 2.5MHz */

+#define NAPI_WEIGHT  64
+
 /* the following must be powers of two */
 #define KORINA_NUM_RDS       64  /* number of receive descriptors */
 #define KORINA_NUM_TDS       64  /* number of transmit descriptors */
@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
      dev->netdev_ops = &korina_netdev_ops;
      dev->ethtool_ops = &netdev_ethtool_ops;
      dev->watchdog_timeo = TX_TIMEOUT;
-     netif_napi_add(dev, &lp->napi, korina_poll, 64);
+     netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);

Please use NAPI_POLL_WEIGHT from linux/netdevice.h

OK, should I resend the whole set or just this one and dependant?

You need to resend everything and please also provide a cover letter,
and a proper patch subject (e.g: git format-patch --cover-letter
--subject="PATCH net-next v2" a..b)

Thanks!
-- 
Florian

Re: [net, 2/6] net: korina: define NAPI_WEIGHT

From: David Miller <davem@davemloft.net>
Date: 2017-01-17 19:09:00

From: Roman Yeryomin <redacted>
Date: Tue, 17 Jan 2017 20:30:44 +0200

On 17 January 2017 at 19:40, David Miller [off-list ref] wrote:

quoted

From: Roman Yeryomin <redacted>
Date: Tue, 17 Jan 2017 19:32:22 +0200

quoted

@@ -77,6 +77,8 @@

 #define MII_CLOCK 1250000    /* no more than 2.5MHz */

+#define NAPI_WEIGHT  64
+
 /* the following must be powers of two */
 #define KORINA_NUM_RDS       64  /* number of receive descriptors */
 #define KORINA_NUM_TDS       64  /* number of transmit descriptors */
@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
      dev->netdev_ops = &korina_netdev_ops;
      dev->ethtool_ops = &netdev_ethtool_ops;
      dev->watchdog_timeo = TX_TIMEOUT;
-     netif_napi_add(dev, &lp->napi, korina_poll, 64);
+     netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);

Please use NAPI_POLL_WEIGHT from linux/netdevice.h

OK, should I resend the whole set or just this one and dependant?

You always must do this for any change whatsoever, a full respin of a
series is always required on any modification whatsoever to any patch.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help