Re: [Patch net] atm: remove an unnecessary loop

On Fri, Jan 13, 2017 at 4:15 PM, Francois Romieu [off-list ref] wrote:

Cong Wang [off-list ref] :

quoted

On Fri, Jan 13, 2017 at 5:23 AM, Francois Romieu [off-list ref] wrote:

[...]

quoted

quoted

alloc_skb() does not need to be in the "while" loop.

This is exactly what I describe in my changelog, don't know
why you want to repeat it...

Because it is still hidden in a while loop.

You turned the alloc from a two level deep "while" loop to a one level
one. I want it at zero level. alloc_skb(..., GFP_KERNEL) fails ?
So let it be done (see patch in other message).

Why I didn't remove all the loops is already stated in the later patch,
you said you read it? I doubt. ;)

[...]

quoted

Please don't expect me to fix many things in one patch, let's
fix each of them separately, agreed?

I am not convinced that several patches are needed to get the whole
picture right.

My guideline for stable fixes is one patch fixes one problem, maybe
not suitable to you I think. Let's agree to disagree. ;)