Thread (17 messages) 17 messages, 5 authors, 2017-01-14

Re: [Patch net] atm: remove an unnecessary loop

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2017-01-14 00:15:24

Cong Wang [off-list ref] :
On Fri, Jan 13, 2017 at 5:23 AM, Francois Romieu [off-list ref] wrote:
[...]
quoted
alloc_skb() does not need to be in the "while" loop.
This is exactly what I describe in my changelog, don't know
why you want to repeat it...
Because it is still hidden in a while loop. 

You turned the alloc from a two level deep "while" loop to a one level
one. I want it at zero level. alloc_skb(..., GFP_KERNEL) fails ?
So let it be done (see patch in other message).

[...]
Please don't expect me to fix many things in one patch, let's
fix each of them separately, agreed?
I am not convinced that several patches are needed to get the whole
picture right.

-- 
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help