Re: [PATCH v2 12/12] net: ethernet: aquantia: Receive side scaling

Hi David,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.10-rc2 next-20170106]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Alexander-Loktionov/net-ethernet-aquantia-Add-AQtion-2-5-5-GB-NIC-driver/20170107-100651
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/aquantia/aq_main.c:14:0:

quoted

drivers/net/ethernet/aquantia/aq_pci_func.h:20:19: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/aq_pci_func.h:20:19: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

   In file included from drivers/net/ethernet/aquantia/aq_main.c:16:0:

quoted

drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.h:32:50: warning: 'struct pci_dev' declared inside parameter list [enabled by default]

   In file included from drivers/net/ethernet/aquantia/aq_main.c:17:0:

quoted

drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.h:32:50: warning: 'struct pci_dev' declared inside parameter list [enabled by default]

   drivers/net/ethernet/aquantia/aq_main.c: In function 'aq_pci_probe_get_hw_ops_by_id':

quoted

drivers/net/ethernet/aquantia/aq_main.c:44:2: warning: passing argument 1 of 'hw_atl_a0_get_ops_by_id' from incompatible pointer type [enabled by default]

   drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.h:32:19: note: expected 'struct pci_dev *' but argument is of type 'struct pci_dev *'

quoted

drivers/net/ethernet/aquantia/aq_main.c:50:2: warning: passing argument 1 of 'hw_atl_b0_get_ops_by_id' from incompatible pointer type [enabled by default]

   drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.h:32:19: note: expected 'struct pci_dev *' but argument is of type 'struct pci_dev *'
   drivers/net/ethernet/aquantia/aq_main.c: In function 'aq_pci_probe':

quoted

drivers/net/ethernet/aquantia/aq_main.c:224:6: warning: passing argument 2 of 'aq_pci_func_alloc' from incompatible pointer type [enabled by default]

   drivers/net/ethernet/aquantia/aq_pci_func.h:17:23: note: expected 'struct pci_dev *' but argument is of type 'struct pci_dev *'
--
   In file included from drivers/net/ethernet/aquantia/aq_nic.c:16:0:

quoted

drivers/net/ethernet/aquantia/aq_pci_func.h:20:19: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/aq_pci_func.h:20:19: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

--
   In file included from drivers/net/ethernet/aquantia/aq_pci_func.c:12:0:

quoted

drivers/net/ethernet/aquantia/aq_pci_func.h:20:19: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/aq_pci_func.h:20:19: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
drivers/net/ethernet/aquantia/aq_pci_func.c:36:23: error: conflicting types for 'aq_pci_func_alloc'

   drivers/net/ethernet/aquantia/aq_pci_func.h:17:23: note: previous declaration of 'aq_pci_func_alloc' was here
--
   In file included from drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.c:15:0:

quoted

drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.h:32:50: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.h:32:50: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.c:897:19: error: conflicting types for 'hw_atl_a0_get_ops_by_id'

   drivers/net/ethernet/aquantia/hw_atl/hw_atl_a0.h:32:19: note: previous declaration of 'hw_atl_a0_get_ops_by_id' was here
--
   In file included from drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.c:14:0:

quoted

drivers/net/ethernet/aquantia/hw_atl/../aq_pci_func.h:20:19: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/hw_atl/../aq_pci_func.h:20:19: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

   In file included from drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.c:18:0:

quoted

drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.h:32:50: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.c:955:19: error: conflicting types for 'hw_atl_b0_get_ops_by_id'

   drivers/net/ethernet/aquantia/hw_atl/hw_atl_b0.h:32:19: note: previous declaration of 'hw_atl_b0_get_ops_by_id' was here
--
   In file included from drivers/net/ethernet/aquantia/hw_atl/hw_atl_utils.c:16:0:

quoted

drivers/net/ethernet/aquantia/hw_atl/../aq_pci_func.h:20:19: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
drivers/net/ethernet/aquantia/hw_atl/../aq_pci_func.h:20:19: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

vim +/aq_pci_func_alloc +36 drivers/net/ethernet/aquantia/aq_pci_func.c

bf5c9193 David VomLehn 2017-01-06   6   * under the terms and conditions of the GNU General Public License,
bf5c9193 David VomLehn 2017-01-06   7   * version 2, as published by the Free Software Foundation.
bf5c9193 David VomLehn 2017-01-06   8   */
bf5c9193 David VomLehn 2017-01-06   9  
bf5c9193 David VomLehn 2017-01-06  10  /* File aq_pci_func.c: Definition of PCI functions. */
bf5c9193 David VomLehn 2017-01-06  11  
bf5c9193 David VomLehn 2017-01-06 @12  #include "aq_pci_func.h"
bf5c9193 David VomLehn 2017-01-06  13  #include "aq_nic.h"
bf5c9193 David VomLehn 2017-01-06  14  #include "aq_vec.h"
bf5c9193 David VomLehn 2017-01-06  15  #include "aq_hw.h"
bf5c9193 David VomLehn 2017-01-06  16  
bf5c9193 David VomLehn 2017-01-06  17  #include <linux/pci.h>
bf5c9193 David VomLehn 2017-01-06  18  #include <linux/interrupt.h>
bf5c9193 David VomLehn 2017-01-06  19  
bf5c9193 David VomLehn 2017-01-06  20  struct aq_pci_func_s {
bf5c9193 David VomLehn 2017-01-06  21  	struct pci_dev *pdev;
bf5c9193 David VomLehn 2017-01-06  22  	struct aq_nic_s *port[AQ_CFG_PCI_FUNC_PORTS];
bf5c9193 David VomLehn 2017-01-06  23  	void __iomem *mmio;
bf5c9193 David VomLehn 2017-01-06  24  	void *aq_vec[AQ_CFG_PCI_FUNC_MSIX_IRQS];
bf5c9193 David VomLehn 2017-01-06  25  	resource_size_t mmio_pa;
bf5c9193 David VomLehn 2017-01-06  26  	unsigned int msix_entry_mask;
bf5c9193 David VomLehn 2017-01-06  27  	unsigned int irq_type;
bf5c9193 David VomLehn 2017-01-06  28  	unsigned int ports;
bf5c9193 David VomLehn 2017-01-06  29  	bool is_pci_enabled;
bf5c9193 David VomLehn 2017-01-06  30  	bool is_regions;
bf5c9193 David VomLehn 2017-01-06  31  	bool is_pci_using_dac;
bf5c9193 David VomLehn 2017-01-06  32  	struct aq_hw_caps_s aq_hw_caps;
bf5c9193 David VomLehn 2017-01-06  33  	struct msix_entry msix_entry[AQ_CFG_PCI_FUNC_MSIX_IRQS];
bf5c9193 David VomLehn 2017-01-06  34  };
bf5c9193 David VomLehn 2017-01-06  35  
bf5c9193 David VomLehn 2017-01-06 @36  struct aq_pci_func_s *aq_pci_func_alloc(struct aq_hw_ops *aq_hw_ops,
bf5c9193 David VomLehn 2017-01-06  37  					struct pci_dev *pdev,
bf5c9193 David VomLehn 2017-01-06  38  					const struct net_device_ops *ndev_ops,
bf5c9193 David VomLehn 2017-01-06  39  					const struct ethtool_ops *eth_ops)

:::::: The code at line 36 was first introduced by commit
:::::: bf5c9193db6618c5e2ffad51a3c671d365740163 net: ethernet: aquantia: PCI operations

:::::: TO: David VomLehn [off-list ref]
:::::: CC: 0day robot [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation