Re: [PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: 2017-01-07 00:30:02
Hi, On 06.01.2017 09:06, Alexander Loktionov wrote:
+ +#define TXT(_T_) #_T_ +#define TXTTXT(_T_) TXT(_T_)
do you really need these (IMHO ugly) macros? AFAICS you only use them to build the driver version string.
+ +#define AQ_CFG_DRV_AUTHOR "aQuantia" +#define AQ_CFG_DRV_DESC "aQuantia Corporation(R) Network Driver" +#define AQ_CFG_DRV_NAME "aquantia" +#define AQ_CFG_DRV_VERSION TXTTXT(NIC_MAJOR_DRIVER_VERSION)"."\ + TXTTXT(NIC_MINOR_DRIVER_VERSION)"."\ + TXTTXT(NIC_BUILD_DRIVER_VERSION)"."\ + TXTTXT(NIC_REVISION_DRIVER_VERSION)
Regards, Lino