Thread (18 messages) 18 messages, 4 authors, 2016-12-30

Re: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

From: Thomas Preisner <hidden>
Date: 2016-12-30 02:38:08
Also in: lkml

On Tue, 2016-12-27 at 22:17:35 +0100, David Dillow wrote:
On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
quoted
In some cases the return value of a failing function is not being used
and the function typhoon_init_one() returns another negative error
code instead.
I'm not sure these changes are especially valuable, since we'll need to
look at the dmesg log anyways to figure out what went wrong, but again I
don't feel strongly.

Fix up the subject issues and I'm happy to ack them.
As requested, here are the patchsets with the fixed subjects.
The subjects aswell as the subject prefixes are more precise now.
Hopefully that's ok.

Patch 1:
Makes the function typhoon_init_one() return a negative error code instead of 0.

Patch 2 [Optional]:
Makes the function typhoon_init_one() return the return value of the
corresponding failing function calls instead of a "fixed" negative error code.

With Regards,
Milan and Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help