Thread (18 messages) 18 messages, 4 authors, 2016-12-30

Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

From: Sergei Shtylyov <hidden>
Date: 2016-12-25 10:07:24
Also in: lkml

Hello!

On 12/25/2016 3:30 AM, Thomas Preisner wrote:
In some cases the return value of a failing function is not being used
and the function typhoon_init_one() returns another negative error
code instead.

Signed-off-by: Thomas Preisner <redacted>
Signed-off-by: Milan Stephan <redacted>
---
 drivers/net/ethernet/3com/typhoon.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
    In addition to what DaveM said, your choise of the subject prefixes is too 
wide -- it would seem that you're fixing all 3com drivers, while you're only 
fixing typhoon. That "typhoon:" alone would have been an appropriate prefix.

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help