Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op
From: Vivien Didelot <hidden>
Date: 2016-12-01 20:41:24
Also in:
lkml
Hi Andrew, Andrew Lunn [off-list ref] writes:
quoted
diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h index ab52c37..9e51405 100644 --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h@@ -765,6 +765,9 @@ struct mv88e6xxx_ops { int (*phy_write)(struct mv88e6xxx_chip *chip, int addr, int reg, u16 val); + /* Switch Software Reset */ + int (*reset)(struct mv88e6xxx_chip *chip); +Hi Vivien In my huge patch series of 6390, i've been using a g1_ prefix for functionality which is in global 1, g2_ for global 2, etc. This has worked for everything so far with the exception of setting which reserved MAC addresses should be sent to the CPU. Most devices have it in g2, but 6390 has it in g1. Please could you add the prefix.
I don't understand. It looks like you are talking about the second part of the comment I made on your RFC patchset, about the Rsvd2CPU feature: https://www.mail-archive.com/netdev@vger.kernel.org/msg139837.html Switch reset routines are implemented in this patch in global1.c as mv88e6185_g1_reset and mv88e6352_g1_reset. 6185 and 6352 are implementation references for other switches. Thanks, Vivien