Thread (8 messages) flat view 8 messages, 3 authors, 2016-11-09

Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks

From: Johan Hovold <johan@kernel.org>
Date: 2016-11-09 09:58:46
Also in: linux-omap, lkml

On Tue, Nov 08, 2016 at 05:19:29PM -0600, Grygorii Strashko wrote:

On 11/03/2016 12:40 PM, Johan Hovold wrote:
quoted
Make sure to drop the references taken by of_get_child_by_name() and
bus_find_device() before returning from cpsw_phy_sel().

Note that holding a reference to the cpsw-phy-sel device does not
prevent the devres-managed private data from going away.

Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...")
Cc: Mugunthan V N <redacted>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
---
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Thanks for the review. Note that David has already applied these, though.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help