Thread (29 messages) flat view 29 messages, 10 authors, 2016-11-09

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-11-07 08:06:02
Also in: linuxppc-dev, lkml

Joe Perches [off-list ref] writes:
On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote:
quoted
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Wed, 2 Nov 2016 22:17:26 +0200
quoted
This introduces the Freescale Data Path Acceleration Architecture
+static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt)
+{
+     u8 i;
+     size_t res = DPAA_BP_RAW_SIZE / 2;
Always order local variable declarations from longest to shortest line,
also know as Reverse Christmas Tree Format.
I think this declaration sorting order is misguided but
here's a possible change to checkpatch adding a test for it
that does this test just for net/ and drivers/net/
And arch/powerpc too please.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help