Thread (2 messages) flat view 2 messages, 2 authors, 2016-11-13

Re: [PATCH iproute2 1/1] tc: print raw qdisc handle.

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-11-13 06:53:43

On Thu, 10 Nov 2016 10:06:32 -0500
Roman Mashak [off-list ref] wrote:
Resending patch after fixing indentation and spaces.

Signed-off-by: Roman Mashak <redacted>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
iproute2 uses kernel coding style. This patch fails basic checkpatch.


WARNING: suspect code indent for conditional statements (8, 11)
#31: FILE: tc/tc_qdisc.c:241:
+	if (!show_raw) {
+	   fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]),

total: 0 errors, 1 warnings, 15 lines checked
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help