[PATCH iproute2 1/1] tc: print raw qdisc handle.

Subsystems: the rest

STALE3564d

2 messages, 2 authors, 2016-11-13 · open the first message on its own page

[PATCH iproute2 1/1] tc: print raw qdisc handle.

From: Roman Mashak <hidden>
Date: 2016-11-10 15:07:00

Resending patch after fixing indentation and spaces.

Signed-off-by: Roman Mashak <redacted>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/tc_qdisc.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c
index 93c9a4c..a8c8386 100644
--- a/tc/tc_qdisc.c
+++ b/tc/tc_qdisc.c
@@ -231,7 +231,15 @@ int print_qdisc(const struct sockaddr_nl *who,
 	if (n->nlmsg_type == RTM_DELQDISC)
 		fprintf(fp, "deleted ");
 
-	fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]), t->tcm_handle>>16);
+	if (!show_raw) {
+		fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]),
+				t->tcm_handle >> 16);
+	} else {
+		fprintf(fp, "qdisc %s %x:[%08x]  ",
+				rta_getattr_str(tb[TCA_KIND]),
+				t->tcm_handle >> 16, t->tcm_handle);
+	}
+
 	if (filter_ifindex == 0)
 		fprintf(fp, "dev %s ", ll_index_to_name(t->tcm_ifindex));
 	if (t->tcm_parent == TC_H_ROOT)
-- 
1.9.1

Re: [PATCH iproute2 1/1] tc: print raw qdisc handle.

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-11-13 06:53:43

On Thu, 10 Nov 2016 10:06:32 -0500
Roman Mashak [off-list ref] wrote:
Resending patch after fixing indentation and spaces.

Signed-off-by: Roman Mashak <redacted>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
iproute2 uses kernel coding style. This patch fails basic checkpatch.


WARNING: suspect code indent for conditional statements (8, 11)
#31: FILE: tc/tc_qdisc.c:241:
+	if (!show_raw) {
+	   fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]),

total: 0 errors, 1 warnings, 15 lines checked
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help