RE: [patch net-next 1/8] Introduce ife encapsulation module

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, November 10, 2016 9:18 PM
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org; Yotam Gigi <redacted>; Ido Schimmel
[off-list ref]; Elad Raz [off-list ref]; Nogah Frankel
[off-list ref]; Or Gerlitz [off-list ref];
jhs@mojatatu.com; geert+renesas@glider.be; stephen@networkplumber.org;
xiyou.wangcong@gmail.com; linux@roeck-us.net; roopa@cumulusnetworks.com
Subject: Re: [patch net-next 1/8] Introduce ife encapsulation module

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 10 Nov 2016 12:23:01 +0100

quoted

+void *ife_encode(struct sk_buff *skb, u16 metalen)

metalen is u16

quoted

+	metalen = htons(metalen);

htons() returns be16.

quoted

+int ife_tlv_meta_encode(void *skbdata, u16 attrtype, u16 dlen, const void

*dval)

quoted

+{
+	u32 *tlv = (u32 *) (skbdata);

...

quoted

+	*tlv = htonl(htlv);

Similar situation here.

I will fix those and we will send a v2.