RE: [v15, 0/7] Fix eSDHC host version register bug
From: Y.B. Lu <hidden>
Date: 2016-10-31 13:13:51
Also in:
linux-arm-kernel, linux-clk, linux-devicetree, linux-i2c, linux-iommu, linux-mmc, linuxppc-dev, lkml
-----Original Message----- From: Arnd Bergmann [mailto:arnd-r2nGTMty4D4@public.gmane.org] Sent: Friday, October 28, 2016 6:54 PM To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Y.B. Lu; linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; Scott Wood; Mark Rutland; Greg Kroah-Hartman; X.B. Xie; M.H. Lian; linux- i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Qiang Zhao; Russell King; Bhupesh Sharma; Joerg Roedel; Jochen Friedrich; Claudiu Manoil; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Rob Herring; Santosh Shilimkar; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Leo Li; iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; Kumar Gala; linuxppc- dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Subject: Re: [v15, 0/7] Fix eSDHC host version register bug On Friday, October 28, 2016 2:50:11 PM CEST Yangbo Lu wrote:quoted
This patchset is used to fix a host version register bug in the T4240-R1.0-R2.0 eSDHC controller. To match the SoC version and revision, 10 previous version patchsets had tried many methods but allof them were rejected by reviewers.quoted
Such as - dts compatible method - syscon method - ifdef PPC method - GUTS driver getting SVR method Anrd suggested a soc_device_match method in v10, and this is the only available method left now. This v11 patchset introduces the soc_device_match interface in soc driver. The first five patches of Yangbo are to add the GUTS driver. This is used to register a soc device which contain soc version and revisioninformation.quoted
The other two patches introduce the soc_device_match method in soc driver and apply it on esdhc driver to fix this bug.Looks good overall. With patch 3 dropped (or an explanation why it's still needed), everything Acked-by: Arnd Bergmann <redacted>
[Lu Yangbo-B47093] Thank you very much:) See my explaination in patch 3 email.
Arnd