RE: [v15, 0/7] Fix eSDHC host version register bug

-----Original Message-----
From: Arnd Bergmann [mailto:arnd@arndb.de]
Sent: Friday, October 28, 2016 6:54 PM
To: linux-arm-kernel@lists.infradead.org
Cc: Y.B. Lu; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; Scott
Wood; Mark Rutland; Greg Kroah-Hartman; X.B. Xie; M.H. Lian; linux-
i2c@vger.kernel.org; linux-clk@vger.kernel.org; Qiang Zhao; Russell King;
Bhupesh Sharma; Joerg Roedel; Jochen Friedrich; Claudiu Manoil;
devicetree@vger.kernel.org; Rob Herring; Santosh Shilimkar;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Leo Li;
iommu@lists.linux-foundation.org; Kumar Gala; linuxppc-
dev@lists.ozlabs.org
Subject: Re: [v15, 0/7] Fix eSDHC host version register bug
=20
On Friday, October 28, 2016 2:50:11 PM CEST Yangbo Lu wrote:

quoted

This patchset is used to fix a host version register bug in the
T4240-R1.0-R2.0 eSDHC controller. To match the SoC version and
revision, 10 previous version patchsets had tried many methods but all

of them were rejected by reviewers.

quoted

Such as
        - dts compatible method
        - syscon method
        - ifdef PPC method
        - GUTS driver getting SVR method Anrd suggested a
soc_device_match method in v10, and this is the only available method
left now. This v11 patchset introduces the soc_device_match interface
in soc driver.

The first five patches of Yangbo are to add the GUTS driver. This is
used to register a soc device which contain soc version and revision

information.

quoted

The other two patches introduce the soc_device_match method in soc
driver and apply it on esdhc driver to fix this bug.

=20
Looks good overall. With patch 3 dropped (or an explanation why it's
still needed), everything
=20
Acked-by: Arnd Bergmann <arnd@arndb.de>

=20
[Lu Yangbo-B47093] Thank you very much:) See my explaination in patch 3 ema=
il.

	Arnd