Re: [PATCH v3 net-next 5/8] net: qualcomm: move MTU handling to qca_common
From: David Miller <davem@davemloft.net>
Date: 2016-10-18 18:29:25
Also in:
lkml
From: Stefan Wahren <redacted> Date: Tue, 18 Oct 2016 13:27:31 +0200
quoted hunk ↗ jump to hunk
The MTU of the QCA7000 is independent from it's host interface (UART,SPI). So move the change_mtu function to qca_common. Signed-off-by: Stefan Wahren <redacted> --- drivers/net/ethernet/qualcomm/qca_common.c | 11 +++++++++++ drivers/net/ethernet/qualcomm/qca_common.h | 3 +++ drivers/net/ethernet/qualcomm/qca_spi.c | 13 +------------ 3 files changed, 15 insertions(+), 12 deletions(-)diff --git a/drivers/net/ethernet/qualcomm/qca_common.c b/drivers/net/ethernet/qualcomm/qca_common.c index 26453a9..9020c57 100644 --- a/drivers/net/ethernet/qualcomm/qca_common.c +++ b/drivers/net/ethernet/qualcomm/qca_common.c@@ -154,3 +154,14 @@ qcafrm_fsm_decode(struct qcafrm_handle *handle, u8 *buf, u16 buf_len, u8 recv_by return ret; } + +int +qcacmn_netdev_change_mtu(struct net_device *dev, int new_mtu) +{ + if ((new_mtu < QCAFRM_ETHMINMTU) || (new_mtu > QCAFRM_ETHMAXMTU)) + return -EINVAL;
In net-next this limiting is implemented by the driver properly setting netdev->min_mtu and netdev->max_mtu respectively. And once you do that, you no longer need this method at all.