Thread (5 messages) flat view 5 messages, 3 authors, 2016-10-19

Re: [PATCH net] net: core: Correctly iterate over lower adjacency list

From: Ido Schimmel <hidden>
Date: 2016-10-19 15:36:30

Hi Dave,

On Wed, Oct 19, 2016 at 10:38:29AM -0400, David Miller wrote:
From: idosch@idosch.org
Date: Wed, 19 Oct 2016 16:57:08 +0300
quoted
From: Ido Schimmel <redacted>

Tamir reported the following trace when processing ARP requests received
via a vlan device on top of a VLAN-aware bridge:
 ...
quoted
The problem is that netdev_all_lower_get_next_rcu() never advances the
iterator, thereby causing the loop over the lower adjacency list to run
forever.

Fix this by advancing the iterator and avoid the infinite loop.

Fixes: 7ce856aaaf13 ("mlxsw: spectrum: Add couple of lower device helper functions")
Signed-off-by: Ido Schimmel <redacted>
Reported-by: Tamir Winetroub <redacted>
Reviewed-by: Jiri Pirko <redacted>
Applied.
Below the patch I noted "Please consider queueing this for 4.8.y", but
you didn't reply and I don't see it here:
https://patchwork.ozlabs.org/bundle/davem/stable/?state=*

So I'm not sure if this was rejected or you just missed my note.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help