Thread (5 messages) flat view 5 messages, 3 authors, 2016-10-19

Re: [PATCH net] net: core: Correctly iterate over lower adjacency list

From: David Miller <davem@davemloft.net>
Date: 2016-10-19 14:38:31

From: idosch@idosch.org
Date: Wed, 19 Oct 2016 16:57:08 +0300
From: Ido Schimmel <redacted>

Tamir reported the following trace when processing ARP requests received
via a vlan device on top of a VLAN-aware bridge:
 ...
The problem is that netdev_all_lower_get_next_rcu() never advances the
iterator, thereby causing the loop over the lower adjacency list to run
forever.

Fix this by advancing the iterator and avoid the infinite loop.

Fixes: 7ce856aaaf13 ("mlxsw: spectrum: Add couple of lower device helper functions")
Signed-off-by: Ido Schimmel <redacted>
Reported-by: Tamir Winetroub <redacted>
Reviewed-by: Jiri Pirko <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help