Thread (45 messages) 45 messages, 10 authors, 2016-09-28

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

flat view

From: Dan Carpenter <hidden>
Date: 2016-09-27 07:09:42
Also in: kernel-janitors, lkml

On Mon, Sep 26, 2016 at 08:38:14PM +0300, Sergei Shtylyov wrote:
quoted
@@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg,
{
	unsigned char outbuf[80];
	unsigned char c;
-	size_t space = sizeof outbuf - 1;
+	size_t space = sizeof(outbuf - 1);
   What?! Does that compile?

[...]
It prints a Smatch warning.  Smatch ignores these if they happen inside
a macro where you pass a pointer and it takes the sizeof() the argument.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help