RE: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses
flat view
From: David Laight <hidden>
Date: 2016-09-26 16:03:48
Also in:
kernel-janitors, lkml
From: SF Markus Elfring
Sent: 26 September 2016 16:45
...
The script "checkpatch.pl" can point information out like the following. WARNING: sizeof … should be sizeof(…)
...
quoted hunk ↗ jump to hunk
--- drivers/isdn/gigaset/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index 2e9382f..d901ed7 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c@@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, { unsigned char outbuf[80]; unsigned char c; - size_t space = sizeof outbuf - 1; + size_t space = sizeof(outbuf - 1);
wrong ... think that is 7 instead of 79. David