Thread (10 messages) 10 messages, 3 authors, 2016-09-30

Re: [PATCH] brcmfmac: implement more accurate skb tracking

From: Rafał Miłecki <zajec5@gmail.com>
Date: 2016-09-26 12:38:46
Also in: linux-wireless, lkml

On 26 September 2016 at 14:13, Rafał Miłecki [off-list ref] wrote:
On 26 September 2016 at 13:46, Arend Van Spriel
[off-list ref] wrote:
quoted
On 26-9-2016 12:23, Rafał Miłecki wrote:
quoted
From: Rafał Miłecki <rafal@milecki.pl>

We need to track 802.1x packets to know if there are any pending ones
for transmission. This is required for performing key update in the
firmware.
The problem we are trying to solve is a pretty old one. The problem is
that wpa_supplicant uses two separate code paths: EAPOL messaging
through data path and key configuration though nl80211.
Can I find it described/reported somewhere?

quoted
quoted
Unfortunately our old tracking code wasn't very accurate. It was
treating skb as pending as soon as it was passed by the netif. Actual
handling packet to the firmware was happening later as brcmfmac
internally queues them and uses its own worker(s).
That does not seem right. As soon as we get a 1x packet we need to wait
with key configuration regardless whether it is still in the driver or
handed over to firmware already.
OK, thanks.
Actually, it's not OK. I was trying to report/describe/discuss this
problem for over a week. I couldn't get much of answer from you.

I had to come with a patch I worked on for quite some time. Only then
you decided to react and reply with a reason for a nack. I see this
patch may be wrong (but it's still hard to know what's going wrong
without a proper hostapd bug report). I'd expect you to somehow work &
communicate with open source community.

-- 
Rafał
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help