Re: [PATCH] brcmfmac: implement more accurate skb tracking
From: Arend Van Spriel <hidden>
Date: 2016-09-26 12:21:24
Also in:
linux-wireless, lkml
From: Arend Van Spriel <hidden>
Date: 2016-09-26 12:21:24
Also in:
linux-wireless, lkml
On 26-9-2016 14:13, Rafał Miłecki wrote:
On 26 September 2016 at 13:46, Arend Van Spriel [off-list ref] wrote:quoted
On 26-9-2016 12:23, Rafał Miłecki wrote:quoted
From: Rafał Miłecki <redacted> We need to track 802.1x packets to know if there are any pending ones for transmission. This is required for performing key update in the firmware.The problem we are trying to solve is a pretty old one. The problem is that wpa_supplicant uses two separate code paths: EAPOL messaging through data path and key configuration though nl80211.Can I find it described/reported somewhere?
Not sure. It is something that I recall from working at Intersil so back in the prism days. Regards, Arend
quoted
quoted
Unfortunately our old tracking code wasn't very accurate. It was treating skb as pending as soon as it was passed by the netif. Actual handling packet to the firmware was happening later as brcmfmac internally queues them and uses its own worker(s).That does not seem right. As soon as we get a 1x packet we need to wait with key configuration regardless whether it is still in the driver or handed over to firmware already.OK, thanks.