Thread (76 messages) 76 messages, 9 authors, 2016-10-19

Re: [RFC v3 19/22] landlock: Add interrupted origin

From: Mickaël Salaün <mic@digikod.net>
Date: 2016-09-14 22:15:43
Also in: cgroups, linux-api, lkml

On 14/09/2016 20:29, Andy Lutomirski wrote:
On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün [off-list ref] wrote:
quoted
This third origin of hook call should cover all possible trigger paths
(e.g. page fault). Landlock eBPF programs can then take decisions
accordingly.

Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Kees Cook <redacted>
---
quoted
+       if (unlikely(in_interrupt())) {
IMO security hooks have no business being called from interrupts.
Aren't they all synchronous things done by tasks?  Interrupts are
driver things.

Are you trying to check for page faults and such?
Yes, that was the idea you did put in my mind. Not sure how to deal with
this.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help