From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:23
Hello David,
This trivial series is similar to [0] for net/ that you already merged, but
for drivers/net. The patches replaces the open coding to check for a Kconfig
symbol being built-in or module, with IS_ENABLED() macro that does the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
[0]: https://lkml.org/lkml/2016/9/9/323
Best regards,
Javier
Javier Martinez Canillas (15):
3c59x: use IS_ENABLED() instead of checking for built-in or module
starfire: use IS_ENABLED() instead of checking for built-in or module
ethernet: amd: use IS_ENABLED() instead of checking for built-in or
module
bnx2: use IS_ENABLED() instead of checking for built-in or module
sundance: use IS_ENABLED() instead of checking for built-in or module
net/fsl_pq_mdio: use IS_ENABLED() instead of checking for built-in or
module
i825xx: use IS_ENABLED() instead of checking for built-in or module
ixgbe: use IS_ENABLED() instead of checking for built-in or module
net: mvneta: use IS_ENABLED() instead of checking for built-in or
module
natsemi: use IS_ENABLED() instead of checking for built-in or module
sfc: use IS_ENABLED() instead of checking for built-in or module
sis900: use IS_ENABLED() instead of checking for built-in or module
stmmac: use IS_ENABLED() instead of checking for built-in or module
hamradio: use IS_ENABLED() instead of checking for built-in or module
iwlegacy: use IS_ENABLED() instead of checking for built-in or module
drivers/net/ethernet/3com/3c59x.c | 2 +-
drivers/net/ethernet/adaptec/starfire.c | 2 +-
drivers/net/ethernet/amd/7990.c | 6 +++---
drivers/net/ethernet/amd/amd8111e.c | 2 +-
drivers/net/ethernet/broadcom/bnx2.c | 2 +-
drivers/net/ethernet/dlink/sundance.c | 2 +-
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 8 ++++----
drivers/net/ethernet/i825xx/82596.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++--
drivers/net/ethernet/marvell/mvneta_bm.h | 2 +-
drivers/net/ethernet/natsemi/ns83820.c | 2 +-
drivers/net/ethernet/sfc/falcon_boards.c | 4 ++--
drivers/net/ethernet/sis/sis900.c | 4 ++--
drivers/net/ethernet/sis/sis900.h | 2 +-
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
drivers/net/hamradio/bpqether.c | 2 +-
drivers/net/wireless/intel/iwlegacy/common.h | 4 ++--
17 files changed, 27 insertions(+), 27 deletions(-)
--
2.7.4
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:25
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/3com/3c59x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -3089,7 +3089,7 @@ static void set_rx_mode(struct net_device *dev)iowrite16(new_mode,ioaddr+EL3_CMD);}-#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)+#if IS_ENABLED(CONFIG_VLAN_8021Q)/* Setup the card so that it can receive frames with an 802.1q VLAN tag.NotethatthismustbedoneaftereachRxResetduetosomebackwardscompatibilitylogicintheCycloneandTornadoASICs*/
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:33
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/amd/7990.c | 6 +++---
drivers/net/ethernet/amd/amd8111e.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:41
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/dlink/sundance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:43
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:46
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/i825xx/82596.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:50
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:04:57
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/marvell/mvneta_bm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:05:00
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/natsemi/ns83820.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:05:03
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/sfc/falcon_boards.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:05:10
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:05:29
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/wireless/intel/iwlegacy/common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:05:31
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/hamradio/bpqether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:06:31
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/sis/sis900.c | 4 ++--
drivers/net/ethernet/sis/sis900.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:08:57
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/broadcom/bnx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Javier Martinez Canillas <hidden> Date: 2016-09-12 14:09:26
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/adaptec/starfire.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Sep 12, 2016 at 4:03 PM, Javier Martinez Canillas
[off-list ref] wrote:
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 12/09/16 15:03, Javier Martinez Canillas wrote:
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
On Mon, 2016-09-12 at 10:03 -0400, Javier Martinez Canillas wrote:
quoted hunk
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
I was wondering what happens if CONFIG_FCOE_MODULE is defined but not
CONFIG_FCOE but then couldn't even find CONFIG_FCOE_MODULE in any
Kconfigs anywhere in the current tree.
Looks good to me.
* Reviewed-by: Greg Rose [off-list ref]
Hi Javier,
On 09/12/2016 04:03 PM, Javier Martinez Canillas wrote:
quoted hunk
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 12 September 2016 16:03:43 CEST, Javier Martinez Canillas [off-list ref] wrote:
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled
either
built-in or as a module, use that macro instead of open coding the
same.
Using the macro makes the code more readable by helping abstract away
some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <redacted>
This trivial series is similar to [0] for net/ that you already merged, but
for drivers/net. The patches replaces the open coding to check for a Kconfig
symbol being built-in or module, with IS_ENABLED() macro that does the same.