Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions
flat view
From: Shmulik Ladkani <hidden>
Date: 2016-09-25 17:59:37
Hi, On Sat, 24 Sep 2016 17:07:12 -0700 Cong Wang [off-list ref] wrote:
One problem to use your code for us is that, the RX side of veth is inside containers, not visible to outside, perhaps we need some more parameter to tell the netns before the device name/index? Thoughts?
Well, this is way trickier... tc_mirred doesn't cope with netns movement of the target device. See 'mirred_device_event': upon NETDEV_UNREGISTER the 'tcfm_dev' gets nullified. (dev_change_net_namespace sequence includes NETDEV_UNREGISTER, dev_net_set, NETDEV_REGISTER). As upposed to veth, which keeps the peer netdev pointer (since veth peers lifetime is coupled), here in act_mirred we can't easily distinguish a "real" NETDEV_UNREGISTER vs a namespace change...