Thread (18 messages) 18 messages, 5 authors, 2016-09-21

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

flat view

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-09-21 02:46:28

On Tue, Sep 20, 2016 at 07:58:03PM +0200, Thomas Graf wrote:
I understand this particular patch as an effort not to duplicate
hash function selection such as jhash vs jhash2 based on key_len.
If the rhashtable params stay non-const as is then this is going
to produce some monstrous code which will be worse than using
jhash unconditionally.

If the rhashtable params are made const then you'll already know
whether jhash or jhash2 is used.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help