Thread (18 messages) 18 messages, 5 authors, 2016-09-21

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

flat view

From: Thomas Graf <tgraf@suug.ch>
Date: 2016-09-20 17:58:07

On 09/20/16 at 05:36pm, Herbert Xu wrote:
Tom Herbert [off-list ref] wrote:
quoted
Split out most of rht_key_hashfn which is calculating the hash into
its own function. This way the hash function can be called separately to
get the hash value.

Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Tom Herbert <redacted>
I don't get this one.  You're just using jhash, right? Why not
call jhash directly instead of rht_get_key_hashfn?
FYI, there is a v2 of this series, just so you don't have to do the
work twice.

I understand this particular patch as an effort not to duplicate
hash function selection such as jhash vs jhash2 based on key_len.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help