Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

On Mon, Sep 12, 2016 at 01:04:57PM +0100, Jakub Kicinski wrote:

Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan
info from skb->vlan_tci") made flow dissector look at vlan_proto
when vlan is present.  Since test_bpf sets skb->vlan_tci to ~0
(including VLAN_TAG_PRESENT) we have to populate skb->vlan_proto.

Fixes false negative on test #24:
test_bpf: #24 LD_PAYLOAD_OFF jited:0 175 ret 0 != 42 FAIL (1 times)

Signed-off-by: Jakub Kicinski <redacted>
Reviewed-by: Dinan Gunawardena <redacted>

Thanks! This is for net-next. Pls mention that in the subj next time.
Acked-by: Alexei Starovoitov <ast@kernel.org>