Thread (4 messages) 4 messages, 4 authors, 2016-09-15

Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

flat view

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2016-09-12 13:31:58

On 09/12/2016 02:04 PM, Jakub Kicinski wrote:
Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan
info from skb->vlan_tci") made flow dissector look at vlan_proto
when vlan is present.  Since test_bpf sets skb->vlan_tci to ~0
(including VLAN_TAG_PRESENT) we have to populate skb->vlan_proto.

Fixes false negative on test #24:
test_bpf: #24 LD_PAYLOAD_OFF jited:0 175 ret 0 != 42 FAIL (1 times)

Signed-off-by: Jakub Kicinski <redacted>
Reviewed-by: Dinan Gunawardena <redacted>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help