Thread (4 messages) flat view 4 messages, 3 authors, 2016-08-01

Re: [PATCH 1/1] net: qlcnic: avoid superfluous assignement

From: zhuyj <zyjzyj2000@gmail.com>
Date: 2016-08-01 02:58:19
Also in: lkml

Sorry.
An inline function will be inserted into the calling function. Why
"Assigning NULL to parmeter dcb has no effect outside of the
inlined function." ?

On Sun, Jul 31, 2016 at 6:07 PM, Heinrich Schuchardt [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Assigning NULL to parmeter dcb has no effect outside of the
inlined function.

Signed-off-by: Heinrich Schuchardt <redacted>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
index 9777e57..f4aa633 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
@@ -45,7 +45,6 @@ struct qlcnic_dcb {
 static inline void qlcnic_clear_dcb_ops(struct qlcnic_dcb *dcb)
 {
        kfree(dcb);
-       dcb = NULL;
 }

 static inline int qlcnic_dcb_get_hw_capability(struct qlcnic_dcb *dcb)
--
2.8.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help