[PATCH 1/1] net: qlcnic: avoid superfluous assignement

Assigning NULL to parmeter dcb has no effect outside of the
inlined function.

Signed-off-by: Heinrich Schuchardt <redacted>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
index 9777e57..f4aa633 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h

@@ -45,7 +45,6 @@ struct qlcnic_dcb {
 static inline void qlcnic_clear_dcb_ops(struct qlcnic_dcb *dcb)
 {
 	kfree(dcb);
-	dcb = NULL;
 }
 
 static inline int qlcnic_dcb_get_hw_capability(struct qlcnic_dcb *dcb)

-- 
2.8.1

Sorry.
An inline function will be inserted into the calling function. Why
"Assigning NULL to parmeter dcb has no effect outside of the
inlined function." ?

On Sun, Jul 31, 2016 at 6:07 PM, Heinrich Schuchardt [off-list ref] wrote:

From: zhuyj <zyjzyj2000@gmail.com>
Date: Mon, 1 Aug 2016 10:57:20 +0800

Sorry.
An inline function will be inserted into the calling function. Why
"Assigning NULL to parmeter dcb has no effect outside of the
inlined function." ?

It doesn't do anything to "dcb" in the calling function, that's not
how inlining works.

The inlined function behaves exactly as if it were called as a
non-inline function from the perspective of side effects visible to
the program.

From: Heinrich Schuchardt <redacted>
Date: Sun, 31 Jul 2016 12:07:37 +0200

Assigning NULL to parmeter dcb has no effect outside of the
inlined function.

Signed-off-by: Heinrich Schuchardt <redacted>

Applied.