Thread (5 messages) flat view 5 messages, 4 authors, 2016-08-24

Re: [PATCH -next] tipc: use kfree_skb() instead of kfree()

From: David Miller <davem@davemloft.net>
Date: 2016-08-24 06:00:35

From: "Xue, Ying" <redacted>
Date: Wed, 24 Aug 2016 02:47:32 +0000
Acked-by: Ying Xue <redacted>
Please do not ACK patches like this.

If you quote the patch with no demarcation in the initial column for
the quoted text, like so:
From: Wei Yongjun [mailto:weiyj.lk@gmail.com] 
Sent: Wednesday, August 24, 2016 7:01 AM
To: Jon Maloy; Xue, Ying; David S. Miller
Cc: Wei Yongjun; netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net
Subject: [PATCH -next] tipc: use kfree_skb() instead of kfree()

From: Wei Yongjun <redacted>

Use kfree_skb() instead of kfree() to free sk_buff.
 ...

then it makes it look like _you_ are posting this patch, so it ends up
again in patchwork and your ACK gets lost.

I truly feel like I've told you this at least one time already before,
so please fix your quoting so that it adheres to the list posting
standards used by everyone else here.

Thank you.

------------------------------------------------------------------------------
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help