[PATCH -next] tipc: use kfree_skb() instead of kfree()

From: Wei Yongjun <redacted>

Use kfree_skb() instead of kfree() to free sk_buff.

Fixes: 0d051bf93c06 ("tipc: make bearer packet filtering generic")
Signed-off-by: Wei Yongjun <redacted>
---
 net/tipc/bearer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 6fc4e3c..28056fa 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c

@@ -529,7 +529,7 @@ void tipc_bearer_xmit(struct net *net, u32 bearer_id,
 		if (likely(test_bit(0, &b->up) || msg_is_reset(buf_msg(skb))))
 			b->media->send_msg(net, skb, b, dst);
 		else
-			kfree(skb);
+			kfree_skb(skb);
 	}
 	rcu_read_unlock();
 }

Acked-by: Ying Xue <redacted>

-----Original Message-----
From: Wei Yongjun [mailto:weiyj.lk@gmail.com] 
Sent: Wednesday, August 24, 2016 7:01 AM
To: Jon Maloy; Xue, Ying; David S. Miller
Cc: Wei Yongjun; netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net
Subject: [PATCH -next] tipc: use kfree_skb() instead of kfree()

From: Wei Yongjun <redacted>

Use kfree_skb() instead of kfree() to free sk_buff.

Fixes: 0d051bf93c06 ("tipc: make bearer packet filtering generic")
Signed-off-by: Wei Yongjun <redacted>
---
 net/tipc/bearer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 6fc4e3c..28056fa 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c

@@ -529,7 +529,7 @@ void tipc_bearer_xmit(struct net *net, u32 bearer_id,
 		if (likely(test_bit(0, &b->up) || msg_is_reset(buf_msg(skb))))
 			b->media->send_msg(net, skb, b, dst);
 		else
-			kfree(skb);
+			kfree_skb(skb);
 	}
 	rcu_read_unlock();
 }

------------------------------------------------------------------------------

From: "Xue, Ying" <redacted>
Date: Wed, 24 Aug 2016 02:47:32 +0000

Acked-by: Ying Xue <redacted>

Please do not ACK patches like this.

If you quote the patch with no demarcation in the initial column for
the quoted text, like so:

From: Wei Yongjun [mailto:weiyj.lk@gmail.com] 
Sent: Wednesday, August 24, 2016 7:01 AM
To: Jon Maloy; Xue, Ying; David S. Miller
Cc: Wei Yongjun; netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net
Subject: [PATCH -next] tipc: use kfree_skb() instead of kfree()

From: Wei Yongjun <redacted>

Use kfree_skb() instead of kfree() to free sk_buff.

 ...

then it makes it look like _you_ are posting this patch, so it ends up
again in patchwork and your ACK gets lost.

I truly feel like I've told you this at least one time already before,
so please fix your quoting so that it adheres to the list posting
standards used by everyone else here.

Thank you.

------------------------------------------------------------------------------

From: Wei Yongjun <redacted>
Date: Tue, 23 Aug 2016 23:01:02 +0000

From: Wei Yongjun <redacted>

Use kfree_skb() instead of kfree() to free sk_buff.

Fixes: 0d051bf93c06 ("tipc: make bearer packet filtering generic")
Signed-off-by: Wei Yongjun <redacted>

Applied, thanks.

------------------------------------------------------------------------------

On 08/24/2016 02:00 PM, David Miller wrote:

From: "Xue, Ying" <redacted>
Date: Wed, 24 Aug 2016 02:47:32 +0000

quoted

Acked-by: Ying Xue <redacted>

Please do not ACK patches like this.

If you quote the patch with no demarcation in the initial column for
the quoted text, like so:

quoted

From: Wei Yongjun [mailto:weiyj.lk@gmail.com] 
Sent: Wednesday, August 24, 2016 7:01 AM
To: Jon Maloy; Xue, Ying; David S. Miller
Cc: Wei Yongjun; netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net
Subject: [PATCH -next] tipc: use kfree_skb() instead of kfree()

From: Wei Yongjun <redacted>

Use kfree_skb() instead of kfree() to free sk_buff.

 ...

then it makes it look like _you_ are posting this patch, so it ends up
again in patchwork and your ACK gets lost.

I truly feel like I've told you this at least one time already before,
so please fix your quoting so that it adheres to the list posting
standards used by everyone else here.

Sorry for bringing such inconvenience for you.
I am sure I will strictly follow the standards in the future.

Regards,
Ying

Thank you.