On 08/22/2016 07:20 PM, Sargun Dhillon wrote:

On Mon, Aug 22, 2016 at 06:22:20PM +0200, Daniel Mack wrote:

quoted

On 08/22/2016 06:06 PM, Pablo Neira Ayuso wrote:

quoted

quoted

This patchset also needs an extra egress hook, not yet known where to
be placed, so two hooks in the network stacks in the end, 

That should be solvable, I'm sure. I can as well leave egress out for
the next version so it can be added later on.

Any idea where you might put that yet? Does dev_xmit seems like a reasonable 
place?

Ah, yes. Thanks for the pointer, that seems to work fine.

If someone uses the netprio, or the net classid controllers, skcd matches
no longer work.

Yes, sock_cgroup_ptr() will fall back to the v2 root in this case.

Ideally, we should fix up these controllers to make them
more v2 friendly.

These controllers do not exist for v2, that's why sock_cgroup_ptr()
behaves that way. What's your idea to fix that up?


Thanks,
Daniel