Re: [RFC PATCH 2/5] cgroup: add bpf_{e,in}gress pointers
From: Tejun Heo <hidden>
Date: 2016-08-17 14:11:15
Hello, On Wed, Aug 17, 2016 at 04:00:45PM +0200, Daniel Mack wrote:
quoted hunk ↗ jump to hunk
@@ -5461,6 +5462,14 @@ static int cgroup_destroy_locked(struct cgroup *cgrp) for_each_css(css, ssid, cgrp) kill_css(css); +#ifdef CONFIG_CGROUP_BPF + if (cgrp->bpf_ingress) + bpf_prog_put(cgrp->bpf_ingress); + + if (cgrp->bpf_egress) + bpf_prog_put(cgrp->bpf_egress); +#endif
This most likely isn't the right place as there still can be sockets associated with the cgroup and packets flowing. The cgroup release path in css_release_work_fn() probably is the right place. Thanks. -- tejun